Deduplicate package extraction between verify-nupkgs and IntegrationTestBuild#15554
Merged
Conversation
…estBuild
Change verify-nupkgs.ps1 to extract packages into the same directory that
IntegrationTestBuild.cs expects (artifacts/tmp/{Config}/extractedPackages/
{PackageFileName}), and write .cache marker files after verification so
IntegrationTestBuild detects the pre-extracted packages and skips
re-extraction during test initialization.
This eliminates the duplicate extraction of 5 NuGet packages + VSIX that
previously happened once during 'build.cmd -pack' (verify-nupkgs.ps1) and
again during test assembly initialization (IntegrationTestBuild.cs).
Closes microsoft#15456
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns NuGet/VSIX extraction paths between eng/verify-nupkgs.ps1 and IntegrationTestBuild.cs to avoid extracting the same packages twice during pack + integration test initialization.
Changes:
- Update
verify-nupkgs.ps1to extract intoartifacts/tmp/{Config}/extractedPackages/{PackageFileName}(matchingIntegrationTestBuildconventions). - Derive verification keys from the package file name (since extraction directory naming changed).
- Write per-package
.cachemarker files to enableIntegrationTestBuildto skip redundant extraction.
… exists - Use 'o' (round-trip/ISO 8601) format for cache marker timestamps in both verify-nupkgs.ps1 and IntegrationTestBuild.cs for deterministic cross-runtime comparison - Add New-Item -Force to ensure extractedPackages directory exists Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nohwnd
added
the
🚢 Ship it!
Youssef1313
approved these changes
Mar 24, 2026
This was referenced Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns \�ng/verify-nupkgs.ps1\ extraction to use the same directory convention as \IntegrationTestBuild.cs, eliminating duplicate extraction of 5 NuGet packages + VSIX.
Before: Packages extracted twice:
After: verify-nupkgs extracts to \�xtractedPackages/{FileName}\ and writes .cache\ markers. IntegrationTestBuild detects the cache and skips re-extraction.
IntegrationTestBuild retains its own extraction logic as a fallback (e.g., on Linux where \�uild.cmd -pack\ isn't run, or when running tests without packing first).
Closes #15456
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com