Enable CA1067 analyzer and fix violations#15560
Merged
Merged
Conversation
Enable the CA1067 (Override Object.Equals when implementing IEquatable<T>) analyzer rule as a warning in .editorconfig. Fix the single violation in OneWayCompatibilityMappingEntry by adding Equals(object) and GetHashCode() overrides that delegate to the existing CompatibilityMappingComparer. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Enables CA1067 as a warning and updates OneWayCompatibilityMappingEntry to properly override object.Equals (and GetHashCode) when implementing IEquatable<T>.
Changes:
- Enable CA1067 analyzer as a warning via
.editorconfig. - Add
Equals(object?)andGetHashCode()overrides toOneWayCompatibilityMappingEntry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Microsoft.TestPlatform.ObjectModel/Nuget.Frameworks/OneWayCompatibilityMappingEntry.cs | Implements required Equals(object?)/GetHashCode() overrides to satisfy CA1067 and align equality behavior. |
| .editorconfig | Turns on CA1067 at warning severity to enforce the rule repo-wide. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
nohwnd
added
the
🚢 Ship it!
Youssef1313
approved these changes
Mar 24, 2026
This was referenced Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the CA1067 analyzer rule (Override Object.Equals when implementing IEquatable) as a warning and fix the single existing violation in OneWayCompatibilityMappingEntry.
Closes #15371