Update post-build template parameters#15591
Conversation
Removed SDL validation parameters from post-build template. Testfx does not have them either and main fails on those parameters being unexpected. If we need this for some report, compliance will tag us.
There was a problem hiding this comment.
Pull request overview
Removes post-build template parameters from the official Azure Pipelines definition to avoid failures from unexpected template parameters.
Changes:
- Removes
parameters:block from thepost-build.ymltemplate invocation. - Drops
publishingInfraVersionandSDLValidationParametersconfiguration previously passed to the post-build template.
| LclPackageId: 'LCL-JUNO-PROD-VSTEST' | ||
|
|
||
| - template: eng\common\templates-official\post-build\post-build.yml@self |
There was a problem hiding this comment.
The PR description states that only SDL validation parameters were removed, but the change also removes publishingInfraVersion: 3 by deleting the entire parameters: block. If publishingInfraVersion is still a supported/required parameter, keep it and remove only the unsupported SDLValidationParameters to match the stated intent (or update the PR description to reflect that publishingInfraVersion is intentionally removed too).
| @@ -361,9 +361,3 @@ extends: | |||
| LclPackageId: 'LCL-JUNO-PROD-VSTEST' | |||
|
|
|||
| - template: eng\common\templates-official\post-build\post-build.yml@self | |||
There was a problem hiding this comment.
Removing the entire parameters: block means the post-build template will run with its defaults (including any default publishing infra version and any default security/compliance behaviors). To avoid unexpected pipeline behavior changes, pass only the parameters that are still supported (e.g., keep publishingInfraVersion: 3 if applicable) and remove just the parameter(s) that caused the 'unexpected' failure.
| - template: eng\common\templates-official\post-build\post-build.yml@self | |
| - template: eng\common\templates-official\post-build\post-build.yml@self | |
| parameters: | |
| publishingInfraVersion: 3 |
Removed SDL validation parameters from post-build template. Testfx does not have them either and vstest main fails on those parameters being unexpected. If we need this for some report, compliance will tag us.
Description
Please add a meaningful description for this change.
Ensure the PR has required unit tests.
Related issue
Kindly link any related issues. E.g. Fixes #xyz.