Skip to content

Update post-build template parameters#15591

Merged
nohwnd merged 1 commit into
mainfrom
nohwnd-patch-6
Mar 26, 2026
Merged

Update post-build template parameters#15591
nohwnd merged 1 commit into
mainfrom
nohwnd-patch-6

Conversation

@nohwnd
Copy link
Copy Markdown
Member

@nohwnd nohwnd commented Mar 26, 2026

Removed SDL validation parameters from post-build template. Testfx does not have them either and vstest main fails on those parameters being unexpected. If we need this for some report, compliance will tag us.

Description

Please add a meaningful description for this change.
Ensure the PR has required unit tests.

Related issue

Kindly link any related issues. E.g. Fixes #xyz.

  • I have ensured that there is a previously discussed and approved issue.

Removed SDL validation parameters from post-build template. Testfx does not have them either and main fails on those parameters being unexpected. If we need this for some report, compliance will tag us.
Copilot AI review requested due to automatic review settings March 26, 2026 18:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes post-build template parameters from the official Azure Pipelines definition to avoid failures from unexpected template parameters.

Changes:

  • Removes parameters: block from the post-build.yml template invocation.
  • Drops publishingInfraVersion and SDLValidationParameters configuration previously passed to the post-build template.

Comment on lines 361 to 363
LclPackageId: 'LCL-JUNO-PROD-VSTEST'

- template: eng\common\templates-official\post-build\post-build.yml@self
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description states that only SDL validation parameters were removed, but the change also removes publishingInfraVersion: 3 by deleting the entire parameters: block. If publishingInfraVersion is still a supported/required parameter, keep it and remove only the unsupported SDLValidationParameters to match the stated intent (or update the PR description to reflect that publishingInfraVersion is intentionally removed too).

Copilot uses AI. Check for mistakes.
@@ -361,9 +361,3 @@ extends:
LclPackageId: 'LCL-JUNO-PROD-VSTEST'

- template: eng\common\templates-official\post-build\post-build.yml@self
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the entire parameters: block means the post-build template will run with its defaults (including any default publishing infra version and any default security/compliance behaviors). To avoid unexpected pipeline behavior changes, pass only the parameters that are still supported (e.g., keep publishingInfraVersion: 3 if applicable) and remove just the parameter(s) that caused the 'unexpected' failure.

Suggested change
- template: eng\common\templates-official\post-build\post-build.yml@self
- template: eng\common\templates-official\post-build\post-build.yml@self
parameters:
publishingInfraVersion: 3

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants