Cleanup filter implementation#15629
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors and modernizes the test case filtering implementation with expression-bodied members, readonly/get-only properties, and small logic simplifications.
Changes:
- Simplified property implementations (expression-bodied / get-only auto-properties).
- Tightened types (e.g.,
sealedclasses) and modernized null checks / comparisons. - Refactored evaluation/iteration logic within filter expression processing.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.TestPlatform.Common/Filtering/TestCaseFilterExpression.cs | Simplifies property getters and streamlines validity/evaluation branching. |
| src/Microsoft.TestPlatform.Common/Filtering/FilterExpressionWrapper.cs | Converts fields/setters to get-only properties; reorganizes fast-filter members. |
| src/Microsoft.TestPlatform.Common/Filtering/FilterExpression.cs | Refactors expression operations and iteration logic; minor correctness/perf tweaks. |
| src/Microsoft.TestPlatform.Common/Filtering/FastFilter.cs | Reorders members; keeps API equivalent while reorganizing property declarations. |
| src/Microsoft.TestPlatform.Common/Filtering/Condition.cs | Seals the type and converts properties to get-only with constructor initialization. |
nohwnd
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just code cleanup.