Port verify-binding-redirects.ps1 to rel/18.5#15719
Merged
nohwnd merged 1 commit intomicrosoft:rel/18.5from Apr 23, 2026
Merged
Port verify-binding-redirects.ps1 to rel/18.5#15719nohwnd merged 1 commit intomicrosoft:rel/18.5from
nohwnd merged 1 commit intomicrosoft:rel/18.5from
Conversation
Ports the binding redirect verification script (and verify-nupkgs.ps1 wiring) from main/rel/18.7. Running against the shipped Microsoft.TestPlatform.*.nupkg layout, the script validates that the newVersion of each assembly binding redirect in vstest.console, testhost.x86, and datacollector app.config files matches the actual assembly version of the DLL shipped next to the exe. In CI it fails with instructions; locally it auto-fixes the app.config files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Flaky on ccparallel. |
This was referenced Apr 28, 2026
Closed
Merged
This was referenced Apr 29, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the binding redirect verification script (and its wiring from �erify-nupkgs.ps1) from
main/rel/18.7torel/18.5, so we can validate on this branch that thenewVersionin each binding redirect actually matches the shipped assembly.The script runs against the extracted
Microsoft.TestPlatform.*.nupkglayout produced byverify-nupkgs.ps1. For each ofvstest.console.exe,testhost.x86.exe, anddatacollector.exeit:<probing privatePath>from the app.config<dependentAssembly>reads the shipped DLL versionnewVersionIn CI it fails with the list of mismatches plus fix instructions. Locally it auto-updates the source
app.configfiles (preserving whitespace and BOM) so you can just commit the result.Ran cleanly on
rel/18.5HEAD (v18.5.0) against a Debug build — everything green, includingSystem.Collections.Immutable 9.0.0.0which was the one we wanted to verify.