Don't print socket transport error in console #4493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
commented
May 29, 2023
| remoteEndPoint, | ||
| localEndPoint); | ||
| error = ioException; | ||
| // Do not pass the error to the caller, the transport was torn down because testhost |
Member
Author
There was a problem hiding this comment.
Not super happy about this, but if we do it later in the code we end up ignoring errors for all types of transports (we have just 1 type now, but the abstractions are there). Or we have to match a specific type of error, and then make sure it was raised here, which is pretty much the same as not raising it at all.
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Evangelink
approved these changes
May 29, 2023
This was referenced Jul 22, 2025
Merged
This was referenced Jan 5, 2026
Open
Open
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0
WiktorPWR/skills-secure-repository-supply-chain#7
Open
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0
wmaliha09/skills-secure-repository-supply-chain#9
Open
Open
Open
Open
Open
Open
Open
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0
pnowosada/skills-secure-repository-supply-chain#7
Open
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0
ewenllarr/skills-secure-repository-supply-chain#7
Open
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0
jdenton89/skills-secure-repository-supply-chain#8
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid forwarding stack error when testhost disconnects unexpectedly. This error steals developer focus from the other more important error, which is either the testhost error message, or simply "testhost crashed" without any additional info.
Related issue
Fix #4461
Kindly link any related issues. E.g. Fixes #xyz.