Fix #16 #17 Add outputDataType option for the ArgMax/ArgMin ops#19
Merged
fdwr merged 3 commits intomicrosoft:mainfrom Jul 25, 2024
Merged
Fix #16 #17 Add outputDataType option for the ArgMax/ArgMin ops#19fdwr merged 3 commits intomicrosoft:mainfrom
fdwr merged 3 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
The 129.0.6614.0 included the merged CL 5721028 - 128.0.6613.5 / 129.0.6614.0
The SD Turbo (Text Encoder) mode failed to run with WebNN EP of ONNX Runtime Web 1.18 on the new 129.0.6614.0 build, so upgraded the EP to internal build for SD Turbo as well in @fdwr PTAL |
Collaborator
👀 Will before I leave today. Thank you Belem. |
Collaborator
Let me know when to merge it. (I moved the text buried in the middle of the text to the top of the description in case Adele tries to merge it). |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR included test packages of required WebNN EP fixes for #16 #17:
selectLastIndexis not supported on CoreML webmachinelearning/webnn#652 ArgMax/Min selectLastIndex is not supported on CoreMLOther changes:
powerPreference: "default"in application code since 353552552 (CL 5716629 will be landed later)The 5721028 fix is not in Canary 128.0.6613.5, need to wait new Canary build to test.