Add no-default-features yml workflow#3053
Merged
Conversation
Collaborator
Author
|
@ChrisDenton here's some more fallout from the https://github.com/microsoft/windows-rs/actions/runs/9207820449/job/25328694260?pr=3053 |
Collaborator
Author
|
Actually looking closer it might be an unrelated nightly change. https://rust-lang.github.io/rust-clippy/master/index.html#/lint_groups_priority |
Collaborator
|
Yeah, I think it's basically saying that |
Collaborator
|
Aside: lint changes have been exhausting recently. |
Collaborator
Author
|
Yes, really losing the value for me. |
Collaborator
|
Oh, looks like you were right the first time. It seems that any group has to be priority -1 even if it doesn't include the lint. |
Collaborator
Author
|
Yep, that's super confusing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #3047 (comment) where @dpaoliello suggested we test crates with no default features.