Simplify how extension code for windows crate works#3110
Merged
kennykerr merged 12 commits intomicrosoft:masterfrom Jun 18, 2024
Merged
Simplify how extension code for windows crate works#3110kennykerr merged 12 commits intomicrosoft:masterfrom
windows crate works#3110kennykerr merged 12 commits intomicrosoft:masterfrom
Conversation
dpaoliello
previously approved these changes
Jun 17, 2024
Collaborator
dpaoliello
left a comment
There was a problem hiding this comment.
Love it! Nice to see a ton of duplicated code and hardcoded lists disappear.
kennykerr
reviewed
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the complexity between
windows-bindgenandwindows. This makes it much easier to write "extension" code for thewindowscrate, by reducing the number of places in the code you need to touch.This also removes the need to run
cargo run -p tool_bindingswhenever you touch the extension code for thewindowscrate. You don't need to update the bindings if you're just working on the extensions. Instead, you just edit extension code, like normal Rust code.The extension code has moved from
.../bindgen/src/rust/extensionstowindows/src/extensions. This puts the code much closer to the code that it extends. Also, the extension code is now just a normal set of Rust modules. This makes the language service (Rust Analyzer) work more naturally; refactoring and go-to-definition and such simply work, rather than pointing to source files that were generated bybindgen.Since the extension code is now just normal Rust modules, I had to add a handful of
use crate::Foo::Bar::BAZ;imports to each extension source file. This seems like a good thing; more signs that this is just normal code.I've staged the changes in a set of commits. You can see how each piece of extension logic was moved, or you can view all the changes as a single set. The last commit applies
rustfmtto the extension code. This wasn't happening before, since those files were not part of any module tree, socargo fmtoverlooked them.