Added extra check for valid arguments in upgrade.

[jedieaston]

• Have you signed the Contributor License Agreement?
• Are you working against an Issue?

---

Resolves #1869.

This PR adds a extra validation for arguments in winget upgrade, making sure that arguments that require a package search (--accept-package-agreements for example) don't cause a empty package search to run.

Tested: manually.

Microsoft Reviewers: Open in CodeFlow

[florelis]

I was also working on some extra checks for arguments to upgrade in #1795. Do you know if there is any conflict or overlap between the changes? I'll try to figure it out later, just wondering if you already know the answer.

(BTW, I love your branch names :))

[jedieaston]

There isn't direct overlap (since this PR adds a check for no query and no list parameters). However, it could be simplified by having those functions present I think. (if !HasArgumentsForSinglePackage(execArgs) && !ShouldListUpgrade(execArgs) would give me the same thing I believe)

Do you want me to throw this in a draft, or do you want to add it to your PR?

[florelis]

Do you want me to throw this in a draft, or do you want to add it to your PR?

I'm not sure how soon I'll complete that PR so I think we could get this change in first. You can grab my changes to the validation to simplify this check if you want, or I'll do it later when dealing with the merge conflicts. Up to you.

[jedieaston]

I merged the bulk of your validation changes (git checkout --patch <branch> <file> is magical :D), if you want to take a peek. I was able to get the same effect via those functions.

[florelis]

Looks good to me, but I'll wait for somebody else to approve it since you used some of my changes.

[yao-msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[JohnMcPMS]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).