Allow winget to install MS Store packages without account by zachcwillson · Pull Request #2095 · microsoft/winget-cli

zachcwillson · 2022-04-14T15:58:30Z

Have you signed the Contributor License Agreement?
Are you working against an Issue?
- Resolves Allow winget to install MS Store packages without account just like the MS Store #1585

Updates comment when enr.Status() == GetEntitlementStatus::NoStoreAccount to indicate it is okay to not have a store account.
Updates the return statement of GetFreeUserEntitlement to return true if enr.Status() == GetEntitlementStatus::NoStoreAccount

Microsoft Reviewers: Open in CodeFlow

update log message for NoStoreAccount and add or check for return statement to return true for GetFreeUserEntitlement if status was no store account

Fix formatting and return statement

JohnMcPMS · 2022-04-14T18:26:33Z

We've been told that we should call GetFreeDeviceEntitlementAsync. I would assume that this would be in response to a GetEntitlementStatus::NoStoreAccount from the user function, or simply called first.

Address feedback around usage of GetFreeDeviceEntitlementAsync, moved state checking logic to its own method

zachcwillson · 2022-04-14T19:57:49Z

Thanks for the tip @JohnMcPMS :)

Update to make logging clear over which entitlement type failed or succeeded

Co-authored-by: JohnMcPMS <johnmcp@microsoft.com>

addressed feedback

zachcwillson

addressed feedback

yao-msft · 2022-04-18T18:40:18Z

/azp run

azure-pipelines · 2022-04-18T18:40:28Z

Azure Pipelines successfully started running 1 pipeline(s).

address feedback

zachcwillson · 2022-04-26T18:13:16Z

/azp run

azure-pipelines · 2022-04-26T18:13:21Z

Commenter does not have sufficient privileges for PR 2095 in repo microsoft/winget-cli

yao-msft · 2022-04-26T19:00:47Z

/azp run

azure-pipelines · 2022-04-26T19:00:56Z

Azure Pipelines successfully started running 1 pipeline(s).

yao-msft · 2022-04-26T21:56:48Z

-                context.Reporter.Info() << Resource::String::MSStoreInstallGetEntitlementNoStoreAccount << std::endl;
-                AICLI_LOG(CLI, Error, << "Get entitlement failed. No Store account.");
+                AICLI_LOG(CLI, Error, << "Get device entitlement.");
+                result = installManager.GetFreeUserEntitlementAsync(productId, winrt::hstring(), winrt::hstring()).get();


User

Device

yao-msft · 2022-04-26T22:01:39Z

/azp run

azure-pipelines · 2022-04-26T22:01:48Z

Azure Pipelines successfully started running 1 pipeline(s).

JohnMcPMS

Not sure how to drop my "request changes" without approving. I agree with the code parts, just a few log lines that are mistargeted.

JohnMcPMS · 2022-04-26T22:11:54Z

/azp run

azure-pipelines · 2022-04-26T22:12:02Z

Azure Pipelines successfully started running 1 pipeline(s).

alexchandel · 2023-02-01T02:59:38Z

Did this not make it into 22H2?

yao-msft · 2023-02-01T19:07:20Z

Did this not make it into 22H2?

This is included in winget v1.3 stable release and later. Though winget is pre-installed in Windosw, all updates are distributed through Microsoft Store. They are available in our Github releases too https://github.com/microsoft/winget-cli/releases

alexchandel · 2023-05-03T01:37:47Z

So when will a version of winget be pre-installed on Windows that doesn't require an account at first use? Windows 12?

denelon · 2023-05-03T21:45:03Z

@alexchandel Windows has a long release cycle. We do check in the "latest" stable version of WinGet into the OS for the next release, but it's often the case that a newer version is available by the time the OS is available to the public.

zachcwillson and others added 2 commits April 13, 2022 20:54

Update MSStoreInstallerHandler.cpp

d8813ee

update log message for NoStoreAccount and add or check for return statement to return true for GetFreeUserEntitlement if status was no store account

Update MSStoreInstallerHandler.cpp

07e0e0a

Fix formatting and return statement

ghost added the Issue-Feature This is a feature request for the Windows Package Manager client. label Apr 14, 2022

zachcwillson marked this pull request as ready for review April 14, 2022 16:03

zachcwillson requested a review from a team as a code owner April 14, 2022 16:03

Update MSStoreInstallerHandler.cpp

28e9dbf

Address feedback around usage of GetFreeDeviceEntitlementAsync, moved state checking logic to its own method

Update MSStoreInstallerHandler.cpp

a5c81f0

Update to make logging clear over which entitlement type failed or succeeded

JohnMcPMS requested changes Apr 14, 2022

View reviewed changes

ghost added the Needs-Author-Feedback Issue needs attention from issue or PR author label Apr 14, 2022

Update src/AppInstallerCLICore/Workflows/MSStoreInstallerHandler.cpp

199fd6a

Co-authored-by: JohnMcPMS <johnmcp@microsoft.com>

ghost removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Apr 15, 2022

zachcwillson and others added 2 commits April 14, 2022 17:30

Update src/AppInstallerCLICore/Workflows/MSStoreInstallerHandler.cpp

b14ae91

Co-authored-by: JohnMcPMS <johnmcp@microsoft.com>

Update MSStoreInstallerHandler.cpp

06e51b5

addressed feedback

zachcwillson commented Apr 15, 2022

View reviewed changes

Comment thread src/AppInstallerCLICore/Workflows/MSStoreInstallerHandler.cpp Outdated

zachcwillson commented Apr 15, 2022

View reviewed changes

yao-msft reviewed Apr 18, 2022

View reviewed changes

Comment thread src/AppInstallerCLICore/Workflows/MSStoreInstallerHandler.cpp Outdated

Update MSStoreInstallerHandler.cpp

4d265e9

address feedback

yao-msft reviewed Apr 26, 2022

View reviewed changes

Comment thread src/AppInstallerCLICore/Workflows/MSStoreInstallerHandler.cpp Outdated

Use device

83e04f6

JohnMcPMS reviewed Apr 26, 2022

View reviewed changes

Comment thread src/AppInstallerCLICore/Workflows/MSStoreInstallerHandler.cpp Outdated

Comment thread src/AppInstallerCLICore/Workflows/MSStoreInstallerHandler.cpp Outdated

Correct logging type

eb1375e

JohnMcPMS approved these changes Apr 26, 2022

View reviewed changes

yao-msft merged commit 7355518 into microsoft:master Apr 26, 2022

Conversation

zachcwillson commented Apr 14, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Microsoft Reviewers: Open in CodeFlow

Uh oh!

JohnMcPMS commented Apr 14, 2022

Uh oh!

zachcwillson commented Apr 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zachcwillson left a comment

Choose a reason for hiding this comment

Uh oh!

yao-msft commented Apr 18, 2022

Uh oh!

azure-pipelines Bot commented Apr 18, 2022

Uh oh!

Uh oh!

zachcwillson commented Apr 26, 2022

Uh oh!

azure-pipelines Bot commented Apr 26, 2022

Uh oh!

yao-msft commented Apr 26, 2022

Uh oh!

azure-pipelines Bot commented Apr 26, 2022

Uh oh!

yao-msft Apr 26, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yao-msft commented Apr 26, 2022

Uh oh!

azure-pipelines Bot commented Apr 26, 2022

Uh oh!

Uh oh!

Uh oh!

JohnMcPMS left a comment

Choose a reason for hiding this comment

Uh oh!

JohnMcPMS commented Apr 26, 2022

Uh oh!

azure-pipelines Bot commented Apr 26, 2022

Uh oh!

alexchandel commented Feb 1, 2023

Uh oh!

yao-msft commented Feb 1, 2023

Uh oh!

alexchandel commented May 3, 2023

Uh oh!

denelon commented May 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zachcwillson commented Apr 14, 2022 •

edited by ghost

Loading