Add database for tracking pins and base implementation for pin commands#2769
Merged
florelis merged 23 commits intomicrosoft:masterfrom Jan 12, 2023
Merged
Add database for tracking pins and base implementation for pin commands#2769florelis merged 23 commits intomicrosoft:masterfrom
florelis merged 23 commits intomicrosoft:masterfrom
Conversation
Member
Author
|
This thing's full of TODOs, many of them intentionally left for the future, but do tell me if there's any I should resolve for this PR. |
Trenly
reviewed
Dec 15, 2022
Co-authored-by: Kaleb Luedtke <trenlymc@gmail.com>
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/AppInstallerCLITests/AppInstallerCLITests.vcxproj.filters # src/AppInstallerCommonCore/AppInstallerCommonCore.vcxproj # src/AppInstallerCommonCore/AppInstallerCommonCore.vcxproj.filters # src/AppInstallerCommonCore/Public/AppInstallerRuntime.h
florelis
commented
Dec 22, 2022
florelis
commented
Dec 22, 2022
yao-msft
reviewed
Jan 9, 2023
Co-authored-by: yao-msft <50888816+yao-msft@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
…nningIndexInterface_1_0.cpp Co-authored-by: yao-msft <50888816+yao-msft@users.noreply.github.com>
Co-authored-by: yao-msft <50888816+yao-msft@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
yao-msft
reviewed
Jan 12, 2023
| { | ||
| Resource::String::SearchId, | ||
| Resource::String::SearchSource, | ||
| Resource::String::SearchVersion, |
Contributor
Member
Author
There was a problem hiding this comment.
I don't think we need it. I believe a user would easily understand what we mean if the header is "Version" and the value is something like "1.2.*". I also didn't actually use "gated version" in any of the resource strings, just in logs and names in the code, so it's not something they'd have seen elsewhere.
yao-msft
reviewed
Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a database for tracking pins and a basic implementation of the
pincommands to add, remove and list them. The implementation for the database is roughly copied from the database for portable packages.IPinningIndexand a v1.0 implementation for it. The database contains a single table, where each pin is a separate row. The fields for each pin areA package available from multiple sources could have multiple independent pins. The operations allowed are adding a pin (
pin add), updating a pin (pin add --force), removing a pin (pin remove), getting all pins (pin list), resetting all pins (pin reset --force), and getting a single pin (to be used on update/install).pincommands with the basic functionality of adding, removing and querying.What is missing from this PR:
Related to #476 and #2611 but does not resolve them yet
Microsoft Reviewers: Open in CodeFlow