Create #163 - Dependencies.md#954
Merged
denelon merged 4 commits intomicrosoft:masterfrom May 11, 2021
denelon:Dependencies
Merged
Create #163 - Dependencies.md#954denelon merged 4 commits intomicrosoft:masterfrom denelon:Dependencies
denelon merged 4 commits intomicrosoft:masterfrom
denelon:Dependencies
Conversation
Misspellings found, please review:
To accept these changes, run the following commands from this repository on this branch |
Contributor
|
Fwiw, the latest version will do a better job of annotating misspellings (you'll get 10 instead of duplicates). |
JohnMcPMS
approved these changes
May 10, 2021
Member
JohnMcPMS
left a comment
There was a problem hiding this comment.
I think this is a fine starting point, but probably needs more details added. One thing that would be good to add now though would be what we are not planning to do. For instance, there has been discussion around a produces/consumes model as well, where a package could state that it produces "JRE" and another that it consumes "JRE", but I don't think that we are planning on doing that here.
Collaborator
Author
|
@jsoref some of the misspellings appear to be part of URLs. Is that expected? |
Misspellings found, please review:
To accept these changes, run the following commands from this repository on this branch |
Misspellings found, please review:
To accept these changes, run the following commands from this repository on this branch |
Contributor
|
@denelon: people make typos in urls, yes :-). Also, a word that appears in a url if it's real is likely to appear elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow