Skip to content

Make a lot of experimental things release#969

Merged
JohnMcPMS merged 2 commits intomicrosoft:masterfrom
JohnMcPMS:thesis
May 18, 2021
Merged

Make a lot of experimental things release#969
JohnMcPMS merged 2 commits intomicrosoft:masterfrom
JohnMcPMS:thesis

Conversation

@JohnMcPMS
Copy link
Copy Markdown
Member

@JohnMcPMS JohnMcPMS commented May 17, 2021

Change

Make list, upgrade, uninstall, and export commands no longer experimental. Also make the REST source implementation not experimental, as well as making Delivery Optimization the default downloader.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner May 17, 2021 22:41
}

[TearDown]
public void TearDown()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public void TearDown()

Should we just delete the tear down?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies to the other 2 tests' setup and teardown if you decide to do so

Copy link
Copy Markdown
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

// While DO still requires an explicit opt-in, we will let failures through.
// When DO becomes the default, we may choose to catch exceptions and fall back to WinINet below.
// If DO becomes an issue, we may choose to catch exceptions and fall back to WinINet below.
// We would need to be careful not to bypass metered networks or other reasons that might
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other reasons

Curious what the other reasons could be?
Is metered networks the reason we do not fall back to wininet for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Delivery Optimization Uninstall an installed App Upgrade an installed App List installed Apps Repository REST API

2 participants