Replace argument for removing a previous manifest#440
Merged
ryfu-msft merged 4 commits intomicrosoft:mainfrom Sep 12, 2023
Merged
Replace argument for removing a previous manifest#440ryfu-msft merged 4 commits intomicrosoft:mainfrom
ryfu-msft merged 4 commits intomicrosoft:mainfrom
Conversation
mdanish-kh
requested review from
a team,
ryfu-msft and
yao-msft
and removed request for
a team
microsoft-github-policy-service
Bot
added
the
Issue-Feature
Contributor
Author
|
I will be following up with a PR to have "replace" work automatically for vanity URLs provided this gets approved |
ryfu-msft
suggested changes
Sep 11, 2023
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@mdanish-kh , Once this PR gets checked, I will work on pulling in the new localized strings from this PR once they are generated and cutting a new release :) |
Contributor
Author
|
@ryfu-msft Thanks, I do have a quick PR incoming after this (to address #72) but I don't mind if that can wait until the next release |
Contributor
I'm happy to wait for that since that will be a really nice addition |
ryfu-msft
approved these changes
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update#277Example PR made with
--replace:There doesn't seem to be a great way to make an option accept optional values. Followed the recommendations listed here: commandlineparser/commandline#674
Microsoft Reviewers: Open in CodeFlow