Conversation
added 2 commits
October 10, 2023 12:34
…ng winget as a package manager
Contributor
Author
Trenly
reviewed
Oct 25, 2023
mdanish-kh
reviewed
Oct 25, 2023
mdanish-kh
reviewed
Oct 25, 2023
Trenly
reviewed
Oct 26, 2023
Contributor
Author
|
mdanish-kh
reviewed
Dec 2, 2023
Contributor
mdanish-kh
left a comment
mdanish-kh
left a comment
There was a problem hiding this comment.
I resolved the threads, but in retrospect, I probably should have let you do that. Sorry.
GitHub allows only the PR author or users with write access to resolve threads, so you did the right thing
Menace me some more, if I messed up your recommendations.
Did some more menacing😄Most are nits that we can choose to leave and iterate upon them after merging in this PR
ryfu-msft
requested review from
a team,
ryfu-msft and
yao-msft
and removed request for
a team
ryfu-msft
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating DSC files can be a challenge.
This script tries to make it easier by leveraging winget search to locate the packages, and then write the file out as YAML.
Microsoft Reviewers: Open in CodeFlow