Skip to content

Fix tense for resource string #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryfu-msft merged 2 commits into from
Aug 8, 2024
Merged

Fix tense for resource string #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bba383
Fix tense for resource string
mdanish-kh Aug 8, 2024
6906214
singular
mdanish-kh Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/WingetCreateCLI/Commands/NewCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ public override async Task<bool> Execute()
bool populated = await this.GitHubClient.PopulateGitHubMetadata(manifests, this.Format.ToString());
if (populated)
{
Logger.InfoLocalized(nameof(Resources.PopulatingGitHubMetadata_Message));
Logger.InfoLocalized(nameof(Resources.PopulatedGitHubMetadata_Message));
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/WingetCreateCLI/Commands/UpdateCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ public async Task<Manifests> UpdateManifestsAutonomously(Manifests manifests)
bool populated = await this.GitHubClient.PopulateGitHubMetadata(manifests, this.Format.ToString());
if (populated)
{
Logger.InfoLocalized(nameof(Resources.PopulatingGitHubMetadata_Message));
Logger.InfoLocalized(nameof(Resources.PopulatedGitHubMetadata_Message));
}
}
}
Expand Down Expand Up @@ -943,7 +943,7 @@ private async Task<Manifests> UpdateManifestsInteractively(Manifests manifests)
bool populated = await this.GitHubClient.PopulateGitHubMetadata(manifests, this.Format.ToString());
if (populated)
{
Logger.InfoLocalized(nameof(Resources.PopulatingGitHubMetadata_Message));
Logger.InfoLocalized(nameof(Resources.PopulatedGitHubMetadata_Message));
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions src/WingetCreateCLI/Properties/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/WingetCreateCLI/Properties/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,8 +1374,8 @@
<data name="CouldNotPopulateGitHubMetadata_Warning" xml:space="preserve">
<value>Could not populate manifest metadata through GitHub's API.</value>
</data>
<data name="PopulatingGitHubMetadata_Message" xml:space="preserve">
<value>GitHub URL detected. The CLI will automatically fill some manifests fields.</value>
<data name="PopulatedGitHubMetadata_Message" xml:space="preserve">
<value>GitHub URL detected. The CLI has automatically filled some manifest fields.</value>
</data>
<data name="ReleaseDate_HelpText" xml:space="preserve">
<value>Date to be used when updating the release date field. Expected format is "YYYY-MM-DD".</value>
Expand Down