Remove empty list fields from the manifest#563
Merged
ryfu-msft merged 1 commit intomicrosoft:mainfrom Dec 10, 2024
Merged
Conversation
mdanish-kh
requested review from
a team,
ryfu-msft and
yao-msft
and removed request for
a team
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@ryfu-msft Looks like it's the same error that you were tackling in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tags: []field in defaultLocale manifest)This PR makes it so that empty list fields like
Tags: [],Agreements: []are removed from the manifest before it's serialized.Validation
Updated unit tests to cover empty lists. For a manual example try:
and see that
Tags: []is not present in the manifest with this changeMicrosoft Reviewers: Open in CodeFlow