Skip to content

New version: sylikc.JPEGView version 1.3.46.0#137327

Merged
microsoft-github-policy-service[bot] merged 1 commit intomicrosoft:masterfrom
KaranKad:sylikc.JPEGView-1.3.46.0-f162e0b8-b021-46d5-8991-cc2a224a9889
Jan 31, 2024
Merged

New version: sylikc.JPEGView version 1.3.46.0#137327
microsoft-github-policy-service[bot] merged 1 commit intomicrosoft:masterfrom
KaranKad:sylikc.JPEGView-1.3.46.0-f162e0b8-b021-46d5-8991-cc2a224a9889

Conversation

@KaranKad
Copy link
Copy Markdown
Contributor

@KaranKad KaranKad commented Jan 31, 2024

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Copy Markdown
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@KaranKad KaranKad changed the title sylikc.JPEGView version 1.3.46.0 New version: sylikc.JPEGView version 1.3.46.0 Jan 31, 2024
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 31, 2024
@stephengillie
Copy link
Copy Markdown
Collaborator

Hi @KaranKad,

This PR's version number 1.3.46.0 has 4 parameters (sets of numbers between dots - major, minor, etc), which is greater than the current manifest's version 1.2.45, which has 3 parameters.

Is this intentional?

(Automated response - build 684)

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jan 31, 2024
@stephengillie
Copy link
Copy Markdown
Collaborator

Hi @KaranKad,

This manifest removes Apps and Features entries that are present in previous PR versions. Should these entries also be added to this version?

(Automated response - build 684.)

@KaranKad
Copy link
Copy Markdown
Contributor Author

@stephengillie
I used 4 parameters as that's what added in ARP. Hence, we do not need to add Apps and Features entries due to already accurate versioning.
image

I just checked that for older versions ARP in inaccurate I will fix it in upcoming PR.
image

@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 31, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot merged commit b5f9a7e into microsoft:master Jan 31, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 31, 2024
@wingetbot
Copy link
Copy Markdown
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@KaranKad KaranKad deleted the sylikc.JPEGView-1.3.46.0-f162e0b8-b021-46d5-8991-cc2a224a9889 branch April 15, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team. Publish-Pipeline-Succeeded Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants