New package: Liquit.Workspace.Agent42 version 4.2.3735.5913#203719
Merged
microsoft-github-policy-service[bot] merged 1 commit intomicrosoft:masterfrom Dec 30, 2024
Conversation
Collaborator
|
|
Collaborator
|
/AzurePipelines run |
wingetbot
added
the
Internal-Error-Dynamic-Scan
microsoft-github-policy-service
Bot
added
the
Needs-Attention
Collaborator
|
/AzurePipelines run |
microsoft-github-policy-service
Bot
removed
Internal-Error-Dynamic-Scan
Contributor
|
@wingetbot run |
Collaborator
|
/AzurePipelines run |
microsoft-github-policy-service
Bot
added
the
Needs-Author-Feedback
stephengillie
added
Validation-Completed
Collaborator
|
Verify: |
stephengillie
approved these changes
Dec 30, 2024
microsoft-github-policy-service
Bot
added
the
Moderator-Approved
mdanish-kh
suggested changes
Dec 30, 2024
Comment on lines
+13
to
+18
| AppsAndFeaturesEntries: | ||
| - DisplayName: Liquit Universal Agent for Windows (x64) | ||
| Publisher: Liquit Software B.V. | ||
| DisplayVersion: 4.2.3735.5913 | ||
| ProductCode: '{F0D42568-BD85-4A9F-A330-1C095773BEE7}' | ||
| UpgradeCode: '{2B15E482-04E7-48A7-897A-12E5F877A2FF}' |
Contributor
There was a problem hiding this comment.
Suggested change
| AppsAndFeaturesEntries: | |
| - DisplayName: Liquit Universal Agent for Windows (x64) | |
| Publisher: Liquit Software B.V. | |
| DisplayVersion: 4.2.3735.5913 | |
| ProductCode: '{F0D42568-BD85-4A9F-A330-1C095773BEE7}' | |
| UpgradeCode: '{2B15E482-04E7-48A7-897A-12E5F877A2FF}' | |
| AppsAndFeaturesEntries: | |
| - DisplayName: Liquit Universal Agent for Windows (x64) | |
| UpgradeCode: '{2B15E482-04E7-48A7-897A-12E5F877A2FF}' |
Comment on lines
+23
to
+28
| AppsAndFeaturesEntries: | ||
| - DisplayName: Liquit Universal Agent for Windows (x86) | ||
| Publisher: Liquit Software B.V. | ||
| DisplayVersion: 4.2.3735.5913 | ||
| ProductCode: '{7BB1F40D-A8A0-4A66-A5D7-3AC0EE8A7651}' | ||
| UpgradeCode: '{2B15E482-04E7-48A7-897A-12E5F877A2FF}' |
Contributor
There was a problem hiding this comment.
Suggested change
| AppsAndFeaturesEntries: | |
| - DisplayName: Liquit Universal Agent for Windows (x86) | |
| Publisher: Liquit Software B.V. | |
| DisplayVersion: 4.2.3735.5913 | |
| ProductCode: '{7BB1F40D-A8A0-4A66-A5D7-3AC0EE8A7651}' | |
| UpgradeCode: '{2B15E482-04E7-48A7-897A-12E5F877A2FF}' | |
| AppsAndFeaturesEntries: | |
| - DisplayName: Liquit Universal Agent for Windows (x86) | |
| UpgradeCode: '{2B15E482-04E7-48A7-897A-12E5F877A2FF}' |
microsoft-github-policy-service
Bot
added
the
Changes-Requested
Contributor
|
@stephengillie - is there a way your automation can check for the condition DisplayVersion == PackageVersion and not approve it in that case? |
microsoft-github-policy-service
Bot
added
the
Needs-Author-Feedback
Collaborator
|
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
Collaborator
|
Edit: Detection is working, just need to fix the canned message.
Hi @mdanish-kh, Yes, this is complete. I reused the old AnF check. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for Pull Requests
Manifests
winget validate --manifest <path>?winget install --manifest <path>?Note:
<path>is the directory's name containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow