Skip to content

New version: Cloudflare.Warp version 25.1.861.0#231884

Merged
microsoft-github-policy-service[bot] merged 2 commits intomicrosoft:masterfrom
PckgrBot:Cloudflare.Warp-25.1.861.0-8200F7F944EA4CAF96096FFCD656CD4E
Feb 22, 2025
Merged

New version: Cloudflare.Warp version 25.1.861.0#231884
microsoft-github-policy-service[bot] merged 2 commits intomicrosoft:masterfrom
PckgrBot:Cloudflare.Warp-25.1.861.0-8200F7F944EA4CAF96096FFCD656CD4E

Conversation

@PckgrBot
Copy link
Copy Markdown
Contributor

@PckgrBot PckgrBot commented Feb 21, 2025

Pull request has been created with komac v2.10.1 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Copy Markdown
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Feb 21, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs-Author-Feedback This needs a response from the author. label Feb 21, 2025
@stephengillie
Copy link
Copy Markdown
Collaborator

Automatic Validation ended with:

2025-02-21T00:15:54.4463974Z ##[error] Manifest Error: Schema Error. [Schema validation failed. Error context: [InstallationMetadata] Description: Value type not permitted by 'type' constraint. Error context: Description: Failed to validate against schema associated with property name 'InstallationMetadata'. ] File: Cloudflare.Warp.installer.yaml Manifest Error: Encountered unexpected root node.
2025-02-21T00:15:54.4476294Z ##[error] Manifest Error: Schema Error. [Schema validation failed. Error context: [InstallationMetadata] Description: Value type not permitted by 'type' constraint. Error context: Description: Failed to validate against schema associated with property name 'InstallationMetadata'. ] File: Cloudflare.Warp.installer.yaml Manifest Error: Encountered unexpected root node.

(Automated response - build 981.)

Comment thread manifests/c/Cloudflare/Warp/25.1.861.0/Cloudflare.Warp.installer.yaml Outdated
@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. Manifest-Validation-Error Manifest validation failed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Feb 21, 2025
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 21, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 22, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot merged commit beb77a7 into microsoft:master Feb 22, 2025
@wingetbot
Copy link
Copy Markdown
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

UpgradeCode: '{1BF42825-7B65-4CA9-AFFF-B7B5E1CE27B4}'
Installers:
- Architecture: x64
InstallerUrl: https://1111-releases.cloudflareclient.com/windows/Cloudflare_WARP_Release-x64.msi
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use fixed URL again? This URL is unstable. ref: #213644

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent a PR in #232872

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we sometimes call a "vanity URL", as it always serves the latest version of the package. We have automation to update these, when a hash mismatch is detected. And the community has an ongoing debate about which type of link should be used, as both have advantages and disadvantages.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I think dynamic is better than vanity. I apologize that my automation kicked off the vanity url again.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sharing it with me. I didn't know it is called vanity URL. Personally, I avoid vanity URLs for all packages. Perhaps including both vanity and fixed URLs might be better, like Google.Chrome (vanity) and Google.Chrome.EXE (fixed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants