Skip to content

add xmake 2.3.5#2640

Closed
eaglu wants to merge 5 commits intomicrosoft:masterfrom
eaglu:master
Closed

add xmake 2.3.5#2640
eaglu wants to merge 5 commits intomicrosoft:masterfrom
eaglu:master

Conversation

@eaglu
Copy link
Copy Markdown

@eaglu eaglu commented Jul 27, 2020

  • Have you signed the Contributor License Agreement?

  • Have you checked that there aren't other open pull requests for the same manifest update/change?

  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?

  • Have you tested your manifest locally with winget install -m <manifest>?


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jul 27, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jul 27, 2020

eaglu The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@ghost ghost added Needs: Attention and removed Needs: author feedback Manifest-Validation-Error Manifest validation failed labels Jul 27, 2020
@azure-pipelines
Copy link
Copy Markdown

Comment was made before the most recent commit for PR 2640 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@ghost ghost removed the Needs: Attention label Jul 27, 2020
@azure-pipelines
Copy link
Copy Markdown

Comment was made before the most recent commit for PR 2640 in repo microsoft/winget-pkgs

@eaglu eaglu changed the title add xmake 2.3.5.0 add xmake 2.3.5 Jul 27, 2020
@KevinLaMS
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jul 28, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jul 28, 2020

eaglu The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@perplexityjeff
Copy link
Copy Markdown
Contributor

perplexityjeff commented Jul 30, 2020

You want to add the following at the end of the file

Switches:
Silent: /S
SilentWithProgress: /S

And change the installer to nullsoft probably.

They also released 2.3.6
https://github.com/xmake-io/xmake/releases

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Aug 6, 2020
@ghost
Copy link
Copy Markdown

ghost commented Aug 6, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@waruqi
Copy link
Copy Markdown
Contributor

waruqi commented Aug 7, 2020

A new pr for xmake v2.3.6, see #2941

@ghost ghost removed the No-Recent-Activity No activity has occurred on this work item for seven days. label Aug 7, 2020
@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Aug 14, 2020
@ghost
Copy link
Copy Markdown

ghost commented Aug 14, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this Aug 21, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Manifest-Validation-Error Manifest validation failed No-Recent-Activity No activity has occurred on this work item for seven days.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants