enabled use of InstallLocation for Oracle.JDK.17

[Cube707]

• Have you signed the Contributor License Agreement?
• Have you checked that there aren't other open pull requests for the same manifest update/change?
• Have you validated your manifest locally with winget validate --manifest <path>?
• Have you tested your manifest locally with winget install --manifest <path>?
• Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

---

made the -l,--location option functional for this package

Microsoft Reviewers: Open in CodeFlow

[wingetbot]

   

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ItzLevvie]

I saw https://stackoverflow.com/a/8841965; which is enabled by default in https://github.com/microsoft/winget-cli/blob/b79e4087821c993f83f7c4731bbde7aa25612c73/src/AppInstallerCommonCore/Manifest/ManifestCommon.cpp#L461 for all packages using MSI

[Cube707]

hm, ok than I must have bodged up somewhere else, because the -l option wasn't working for me. I will test again....

[Cube707]

@lutzroeder did some more Testing and even on a fresh Win10 VM it isn't working as expected:

All of the following result in a installation to the default directory, NOT to the given directory:

winget install Oracle.JDK.17 -l C:\ProgStuff\jdk
winget install Oracle.JDK.17 -l "C:\ProgStuff\jdk"
winget install Oracle.JDK.17 --override "/passive TARGETDIR=C:\ProgStuff\jdk"

The only thing that works and results in a different installation directory is:

winget install Oracle.JDK.17 --override "/passive INSTALLDIR=C:\ProgStuff\jdk"

[ItzLevvie]

Looks like you were right.

I double-checked on a VM and it looks like this installer doesn't support TARGETDIR; only INSTALLDIR.

[Cube707]

reading the link you provided, as I understand it, this is also the correct behavior:

INSTALLDIR represents [..] such as the end user launching Setup.exe [..]

TARGETDIR represents [..] when the user runs Setup.exe or MsiExec.exe with the /a command-line switch

the targetdir option may not be the correct option here? The /a switch for the msi process is not used or is it?

[ghost]

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

Hello @Cube707,
Validation has completed.

[Cube707]

@ItzLevvie I tested a few more packages and there seems to be some more inconsistency.

ChristianHohnstadt.xca and StrawberryPerl.StrawberryPerl seem to suffer from the same problem while Borvid.HttpMasterExpress works absoloutely fine as is and doesn't work with the INSTALLDIR option.

just using both options at the same time seems to work fine though. At least in my quick tests.

should I open a issue about this?

[wingetbot]

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

[OfficialEsco]

should I open a issue about this?

Please do, this will break waaaaaaaaaaaaay too many Packages

Just for safety, make a issue here https://github.com/microsoft/winget-cli/issues not on winget-pkgs =))