Save As doesn't rename workbook

[lewing]

When pages were implemented the "Save As" action no longer updated the workbook name. Is this the behavior we intend to keep or should we revisit the naming logic?

[sandyarmstrong]

Points to consider:

• If "Save As" changes the title, should it do so if the user already changed it to be different from the file name?
• Should workbooks have separate titles if the user never specifically modified it?
• Who uses "Save As", and how do they want it to behave?

[hollywoof]

I've come across this same "annoying" behaviour.

I've set up a template file for some people I'm teaching to code... It's a "template.workbook" file... When they edit it they want to save it as "getBooks.workbook" or "analyseOrders.workbook" or... but every single file they've saved carries on showing the title as "template".

---

My answers to your questions are:

If "Save As" changes the title, should it do so if the user already changed it to be different from the file name?

Yes!

Should workbooks have separate titles if the user never specifically modified it?

No - happy with default (but if you want to use "newWorkbook107" then that'd also be ok (not bothered!)

Who uses "Save As", and how do they want it to behave?

See above "template" example use case.

---

Looks like the code that could be changed is in WorkbookPackage in public void Save (IWorkbookSaveOperation operation) - it's these lines:

            if (IndexPage != null && IndexPage.IsUntitled)
                IndexPage.Title = LogicalPath.NameWithoutExtension;

I'd just recommend we just remove the && IndexPage.IsUntitled test

[slodge]

Ahem... sorry - logged in as "hollywoof" instead of "slodge" again.
Can easily send a PR for this one if you're happy with it.

[slodge]

Another benefit of this fix is that it will change some non-standard Save As behaviour which occurs when (tested on Windows):

1. User creates a workbook and saves it as "MyWorkbook.workbook"
2. User chooses "Save As" and saves it as "JonWorkbook.workbook"
3. User chooses "Save As" - the name suggested in the "SaveAs" dialog is "MyWorkbook.workbook" - which is not what is expected (should be "JonWorkbook.workbook"?)

[abock]

I would happily entertain a PR that makes "Save As" behavior more consistent with other applications.