This repository was archived by the owner on Nov 16, 2023. It is now read-only.
CodeAnalysis: Resolving: add Mono's DllMap support#305
Merged
abock merged 4 commits intomicrosoft:masterfrom May 22, 2018
Merged
CodeAnalysis: Resolving: add Mono's DllMap support#305abock merged 4 commits intomicrosoft:masterfrom
abock merged 4 commits intomicrosoft:masterfrom
Conversation
abock
requested review from
bojanrajkovic,
lewing and
sandyarmstrong
as code owners
abock
force-pushed
the
dllmap
branch
3 times, most recently
from
c73410f to
d6a6f7b
Compare
lewing
previously approved these changes
May 21, 2018
abock
force-pushed
the
dllmap
branch
5 times, most recently
from
0974913 to
7b567a5
Compare
Similar to our Sdk type, but just for runtime.
This is a managed implementation of Mono's DLL mapping support that allows for platform-specific mapping of native libraries and symbols within them. We will use this as a basis for providing better native library loading support for NuGet in .NET Core in particular via AssemblyLoadContext LoadUnmanagedDll(string unmanagedDllName). Unfortunately AssemblyLoadContext does not support symbol mapping, but it is implemented in the DllMap in this commit should the ability be introduced in the future.
bojanrajkovic
approved these changes
May 22, 2018
Contributor
bojanrajkovic
left a comment
bojanrajkovic
left a comment
There was a problem hiding this comment.
Looks good!
I might've condensed the Architecture switch in ToString seeing as every case does essentially the same operation, but it's neither here nor there.
sandyarmstrong
approved these changes
May 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a managed implementation of Mono's DLL mapping support that allows for platform-specific mapping of native libraries and symbols within them.
We will use this as a basis for providing better native library loading support for NuGet in .NET Core in particular via
AssemblyLoadContext.LoadUnmanagedDll(string unmanagedDllName).Unfortunately
AssemblyLoadContextdoes not support symbol mapping, but it is implemented in theDllMapin this commit should the ability be introduced in the future.This is likely a good basis for #204.