This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Save workbook changes - allow workbooks with dependencies to be saved independently of their dependencies#502
Open
slodge wants to merge 3 commits intomicrosoft:1.5-releasefrom
Open
Save workbook changes - allow workbooks with dependencies to be saved independently of their dependencies#502slodge wants to merge 3 commits intomicrosoft:1.5-releasefrom
slodge wants to merge 3 commits intomicrosoft:1.5-releasefrom
Conversation
slodge
requested review from
abock,
lewing and
sandyarmstrong
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is slightly larger, but looks to address the file saving behavior in #500
This PR is not ready to merge yet. It requires review by Xamarin, plus it would require work in other clients (e.g. Mac) before it could be merged. Currently only WPF has been implemented.
Things to consider:
Signedsave option? (it wasn't used in Windows at least)Overall, I'm not sure this PR will ever get fully merged.... but I'm putting it in for consideration...