Improve error message for passing vector<bool> as array_view #611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::vector<bool>is not a conformant array ofbool. Passing it toarray_view<bool>results in a long incomprehensible error message because there is nodata()member. Add specializations for "constructingarray_view<bool>fromstd::vector<bool>" so we can provide a clearer error message.Old error message:
New error message;
Note that we specialize only in the case of
array_view<bool>. That way, if you pass astd::vector<bool>to a function expectingarray_view<hstring>(say), you don't get an error message telling you to use something (std::array<bool>) that won't work. (Should we have a separate error message for type mismatch? Maybe this is good enough for now.)Fixes #568