Skip to content

Conversation

@emmanuel-karanja
Copy link
Contributor

Fixes to enhance splitting:

  1. Add a double space to the function contents as they get generated by CompatibilityAdapterBuilder so that we don't have overlapping functions in the legacy .psm1 file.
  2. Provide a reverse mapper i.e. scans the directory structure of the sub-modules and creates a newModuleMapping.json for comparison with moduleMapping.json to expedite audit.
  3. Enhancement to doc splitting code to omit common files that don't need doc mapping.

@emmanuel-karanja emmanuel-karanja requested a review from a team as a code owner November 28, 2024 08:50
@emmanuel-karanja emmanuel-karanja added Ready For Review The PR Ready for Review P0 Highest priority labels Nov 28, 2024
@learn-build-service-prod
Copy link

Learn Build status updates of commit a8a67df:

✅ Validation status: passed

File Status Preview URL Details
build/Create-ModuleMapping.ps1 ✅Succeeded
build/Split-Docs.ps1 ✅Succeeded
build/Split-EntraModule.ps1 ✅Succeeded
module/Entra/config/moduleMapping.json ✅Succeeded
module/Entra/config/ModuleMetadata.json ✅Succeeded
module/EntraBeta/config/ModuleMetadata.json ✅Succeeded
src/CompatibilityAdapterBuilder.ps1 ✅Succeeded
src/EntraModuleBuilder.ps1 ✅Succeeded
src/EntraModuleSplitter.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit edf108b:

✅ Validation status: passed

File Status Preview URL Details
build/Create-ModuleMapping.ps1 ✅Succeeded
build/Split-Docs.ps1 ✅Succeeded
build/Split-EntraModule.ps1 ✅Succeeded
module/Entra/config/moduleMapping.json ✅Succeeded
module/Entra/config/ModuleMetadata.json ✅Succeeded
module/EntraBeta/config/ModuleMetadata.json ✅Succeeded
src/CompatibilityAdapterBuilder.ps1 ✅Succeeded
src/EntraModuleBuilder.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@KenitoInc KenitoInc merged commit 5048031 into modularize Dec 11, 2024
3 checks passed
KenitoInc pushed a commit that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P0 Highest priority Ready For Review The PR Ready for Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants