Skip to content

Conversation

@emmanuel-karanja
Copy link
Contributor

@emmanuel-karanja emmanuel-karanja commented Mar 17, 2025

Add Enable-EntraAzureADAlias to the RootModule .psm1 file for 'Microsoft.Entra'. Involved:

  1. Removing 'Enable-EntraAzureADAlias' from individual sub-modules.
  2. Adding Enable-EntraAzureADAlias to the 'Microsoft.Entra.psm1' file.
  3. Inject RootModule section of the Microsoft.Entra.psd1 file.
  4. Adding 'Enable-EntraAzureADAlias to the FunctionsToExport section of Microsoft.Entra.psd1.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 4b0ecb5:

✅ Validation status: passed

File Status Preview URL Details
build/Create-EntraModule.ps1 ✅Succeeded
module/Entra/Microsoft.Entra/Applications/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Authentication/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Authentication/Revoke-EntraUserAllRefreshToken.ps1 ✅Succeeded
module/Entra/Microsoft.Entra/DirectoryManagement/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Governance/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Groups/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Reports/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/SignIns/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Users/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Users/Get-EntraUser.ps1 ✅Succeeded
src/EntraModuleBuilder.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@emmanuel-karanja emmanuel-karanja added the P0 Highest priority label Mar 17, 2025
@learn-build-service-prod
Copy link

Learn Build status updates of commit 8399248:

✅ Validation status: passed

File Status Preview URL Details
build/Create-EntraModule.ps1 ✅Succeeded
module/Entra/Microsoft.Entra/Applications/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Authentication/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Authentication/Revoke-EntraUserAllRefreshToken.ps1 ✅Succeeded
module/Entra/Microsoft.Entra/DirectoryManagement/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Governance/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Groups/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Reports/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/SignIns/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Users/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Users/Get-EntraUser.ps1 ✅Succeeded
src/EntraModuleBuilder.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@emmanuel-karanja emmanuel-karanja added the Ready For Review The PR Ready for Review label Mar 17, 2025
@SamErde
Copy link
Contributor

SamErde commented Mar 21, 2025

I have a design/philosophy question about this change: does moving this function to the Microsoft.Entra base module potentially break aspects of the modularized design?

Full Disclosure: My usage and testing has not focused at all on maintaining backwards compatibility with scripts that use the AzureAD module. However, consider this potential scenario:

An admin has the Microsoft.Entra.Authentication and Microsoft.Entra.Users sub-modules installed and can't/doesn't want to install any of the other modules for whatever reason. If they are still relying on aliases, would this break that functionality for them?

  • It's definitely an edge case.
  • It definitely still makes sense to consolidate general functions that aren't required directly for a sub-module's specific feature set.

Just thinking this through, and curious about your thoughts. Thanks!

@KenitoInc
Copy link
Collaborator

I have a design/philosophy question about this change: does moving this function to the Microsoft.Entra base module potentially break aspects of the modularized design?

Full Disclosure: My usage and testing has not focused at all on maintaining backwards compatibility with scripts that use the AzureAD module. However, consider this potential scenario:

An admin has the Microsoft.Entra.Authentication and Microsoft.Entra.Users sub-modules installed and can't/doesn't want to install any of the other modules for whatever reason. If they are still relying on aliases, would this break that functionality for them?

  • It's definitely an edge case.
  • It definitely still makes sense to consolidate general functions that aren't required directly for a sub-module's specific feature set.

Just thinking this through, and curious about your thoughts. Thanks!

Hey @SamErde
That was the original thinking we had when the consolidated aliases per sub-module. However the issue is since AzureAD was one module, customers migrating don't need to know which Entra Sub-module relates to the AzureAD function they are aliasing.

@SamErde
Copy link
Contributor

SamErde commented Mar 24, 2025

Thanks, that makes sense!

@learn-build-service-prod
Copy link

Learn Build status updates of commit c76b4dc:

✅ Validation status: passed

File Status Preview URL Details
build/Create-EntraModule.ps1 ✅Succeeded
module/Entra/Microsoft.Entra/Applications/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Authentication/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/DirectoryManagement/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Governance/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Groups/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Reports/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/SignIns/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Users/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Users/Get-EntraUser.ps1 ✅Succeeded
src/EntraModuleBuilder.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit fbee6ce:

✅ Validation status: passed

File Status Preview URL Details
build/Create-EntraModule.ps1 ✅Succeeded
module/Entra/Microsoft.Entra/Applications/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Authentication/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/DirectoryManagement/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Governance/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Groups/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Reports/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/SignIns/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Users/Enable-EntraAzureADAlias.ps1 ✅Succeeded n/a (file deleted or renamed)
module/Entra/Microsoft.Entra/Users/Get-EntraUser.ps1 ✅Succeeded
src/EntraModuleBuilder.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@KenitoInc KenitoInc merged commit 582b582 into main Mar 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P0 Highest priority Ready For Review The PR Ready for Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants