Skip to content

Conversation

@marabooy
Copy link
Contributor

Weekly Permissions sync 2025-11-16

@marabooy marabooy requested a review from a team as a code owner November 16, 2025 00:40
Copilot AI review requested due to automatic review settings November 16, 2025 00:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs a weekly permissions sync that adds new API endpoint permissions across multiple permission scopes. The changes primarily introduce support for workHoursAndLocations settings endpoints, a new CloudPC client usage report endpoint, and a new Copilot retrieval endpoint.

Key Changes:

  • Added workHoursAndLocations endpoints with full CRUD operations (GET, POST, PUT, PATCH, DELETE) under Calendars.Read and Calendars.ReadWrite permission scopes
  • Added workHoursAndLocations endpoints under MailboxSettings.Read and MailboxSettings.ReadWrite permission scopes
  • Added retrieveCloudPcClientUsageReport endpoint under CloudPC.ReadWrite.All permission scope
  • Added copilot/retrieval endpoint under FileStorageContainer.Selected permission scope

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 5273 to 5277
"/me/settings/workHoursAndLocations/occurrencesView(startDateTime={value},endDateTime={value})": "least=DelegatedWork",
"/me/settings/workHoursAndLocations/recurrences": "least=DelegatedWork",
"/users/{id}/settings/workHoursAndLocations": "",
"/users/{id}/settings/workHoursAndLocations/occurrencesView(startDateTime={value},endDateTime={value})": "least=DelegatedWork",
"/users/{id}/settings/workHoursAndLocations/recurrences": "least=DelegatedWork"
Copy link

Copilot AI Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent permission annotations for similar paths. In this block (lines 5273-5277), child paths like occurrencesView and recurrences have "least=DelegatedWork" annotations. However, in the similar block at lines 5732-5737, these same paths have empty string "" annotations instead. The annotations should be consistent across similar permission blocks.

Copilot uses AI. Check for mistakes.
Comment on lines 29955 to 29956
"/me/settings/workHoursAndLocations": "",
"/users/{id}/settings/workHoursAndLocations": ""
Copy link

Copilot AI Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent permission annotations for the same paths. These GET paths use empty string "" annotations, but at lines 29835-29836, the identical paths in MailboxSettings.Read permission use "least=DelegatedWork" annotations. The annotations should be consistent across permission scopes for the same endpoints.

Copilot uses AI. Check for mistakes.
@jasonjoh jasonjoh closed this Nov 18, 2025
@jasonjoh jasonjoh deleted the permissions-update/2025-11-16 branch December 1, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants