Skip to content

Conversation

@baywet
Copy link
Member

@baywet baywet commented Sep 18, 2020

@baywet baywet self-assigned this Sep 18, 2020
@baywet baywet force-pushed the bugfix/exclude-site-delta-overload branch from d7da1cc to d582354 Compare September 18, 2020 13:15
@baywet
Copy link
Member Author

baywet commented Sep 18, 2020

@zengin @MIchaelMainer FYI I originally had run the XSLT on the raw/clean output but I think it's a multi-step process and on top of removing the function I specifically wanted to remove, it removed a bunch of annotations for description (Lines 48000 and ongoing). I consequently rolled back that change and I guess we'll do it by triggering the CI. Let me know if I'm missing anything.

@zengin
Copy link
Contributor

zengin commented Sep 18, 2020

@baywet yeah, the full CI pipeline has a TransformWithDocs step and that is probably what is missing in your local run steps.
We have a test input-output pair in the CSDL folder. Do you mind adding your case into the test XML? There is a PowerShell script in the same folder to quickly run the transform as well.

Note to self: It would be worth thinking about writing a PowerShell script to go end to end and generate a quick diff compared to the last transform (may need snapshotting docs repo to avoid diffs in descriptions).

@baywet
Copy link
Member Author

baywet commented Sep 18, 2020

Added, merging. Thanks for the review! :)

@baywet baywet merged commit 5a14e6f into master Sep 18, 2020
@baywet baywet deleted the bugfix/exclude-site-delta-overload branch September 18, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants