Fix large file upload #1548
Merged
Fix large file upload #1548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
reviewed
Apr 17, 2024
Suggested modification to the chunkInputStream method: From the second pass through this method, the code in the line "int lengthAssert = stream.read(buffer, begin, length);" throws the exception java.lang.IndexOutOfBoundsException when trying to assign the read bytes to a non-existent position in the buffer. The suggested change implies changing InputStream to FileInputStream throughout the LargeFileUploadTask class.
According to the documentation: public int read(byte[] b, int off, int len) throws IOException The first byte read is stored into element b[off], the next one into b[off+1], and so on. However, from the second pass through the chunkInputStream method, off is greater than any position of b and therefore, b[off] does not exist.
Changed chunkInputStream method in LargeFileUploadTask to resolve IndexOutOfBoundsException when uploading large files
baywet
requested changes
Apr 19, 2024
|
baywet
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexOutOfBoundsExceptioncontent-lengthheader instead of okHttp's nativeResponsecontentLength()which is unreliable at times or checking ifbody()or Response is null since it'll always be non-null based on our use ofCall.execute()This fixes Outlook LFU scenarios by preventing it from trying to parse a null body.
Call.execute()which will always have non-nullbody().closes #1543
closes microsoftgraph/msgraph-sdk-java#1818
closes microsoftgraph/msgraph-sdk-java#1806
closes microsoftgraph/msgraph-sdk-java#1943