- replaces simple json by gson #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lespea
reviewed
Sep 10, 2020
zengin
approved these changes
Sep 10, 2020
Contributor
zengin
left a comment
zengin
left a comment
There was a problem hiding this comment.
Would be nice to address the regex issue in another PR. I am more concerned about the correctness aspect given that . matches more than a dot. Do you mind capturing that as a separate issue?
Thanks for all the finals btw.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoftgraph/msgraph-sdk-java#457
Changes proposed in this pull request
Other links