Change default timeout to align with other sdk languages. #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrueastman
requested review from
MIchaelMainer,
baywet,
ddyett,
ramsessanchez and
zengin
as code owners
|
Kudos, SonarCloud Quality Gate passed! |
baywet
approved these changes
Mar 20, 2023
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thanks, those changes need to be replicated in kiota java I believe.
Contributor
Author
|
True. Thanks for the heads up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes microsoftgraph/msgraph-sdk-java#1381
Related to microsoftgraph/msgraph-sdk-java#1288
OKHttpinitializes the client with a default timeout of 10 seconds. This aligns the timeout value with other sdks to 100 seconds to reduce possibilities of timeout errors on the client.