Skip to content

Replace @Nullable annotations with @Nonnull in BaseRequestBuilder#784

Merged
baywet merged 1 commit intomicrosoftgraph:devfrom
mspiess:issue-783
Apr 14, 2023
Merged

Replace @Nullable annotations with @Nonnull in BaseRequestBuilder#784
baywet merged 1 commit intomicrosoftgraph:devfrom
mspiess:issue-783

Conversation

@mspiess
Copy link
Contributor

@mspiess mspiess commented Apr 5, 2023

Fixes #783

Changes proposed in this pull request

  • Replacing faulty @Nullable annotation with correct @Nonnull annotations

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
Can you add an entry in the changelog (new patch bump, date it to tomorrow, add the change in changed)
as well a bump the patch in gradle.properties please?
https://github.com/microsoftgraph/msgraph-sdk-java-core/blob/dev/gradle.properties
https://github.com/microsoftgraph/msgraph-sdk-java-core/blob/dev/CHANGELOG.md

@mspiess
Copy link
Contributor Author

mspiess commented Apr 5, 2023

@microsoft-github-policy-service agree

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes.

@baywet baywet enabled auto-merge April 5, 2023 19:43
@mspiess
Copy link
Contributor Author

mspiess commented Apr 14, 2023

Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator

Is there anything I can do about this?

@baywet baywet disabled auto-merge April 14, 2023 19:44
@baywet baywet merged commit 7b6ab90 into microsoftgraph:dev Apr 14, 2023
@baywet
Copy link
Member

baywet commented Apr 14, 2023

no sorry for forgetting about this PR and thanks for the nudge

@mspiess mspiess deleted the issue-783 branch April 14, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BaseRequestBuilder.getRequestUrl() declared @Nullable

2 participants