-
Notifications
You must be signed in to change notification settings - Fork 145
Closed
Labels
ADO to GitHub automation labelIssue caused by core project dependency modules or libraryIssue caused by core project dependency modules or libraryenhancementfixedtracked
Milestone
Description
This is a very common pattern in the generated code:
public interface IBaseMessageCollectionRequestBuilder extends IRequestBuilder {
IMessageCollectionRequest buildRequest();
IMessageCollectionRequest buildRequest(final java.util.List<Option> requestOptions);
...
Firstly the final keyword doesn't do anything and can be chucked.
Secondly, a varargs overload would make life easier for the client:
IMessageCollectionRequest buildRequest(Option... requestOptions);
Without the varargs overload I have to do this (using guava dependency as well):
.buildRequest(Lists.newArrayList(new QueryOption("filter", "isRead eq false")));
I would like to do:
.buildRequest(new QueryOption("filter", "isRead eq false"));
AB#6039
pappk
Metadata
Metadata
Assignees
Labels
ADO to GitHub automation labelIssue caused by core project dependency modules or libraryIssue caused by core project dependency modules or libraryenhancementfixedtracked