Skip to content

Conversation

@davidmoten
Copy link
Contributor

@davidmoten davidmoten commented Nov 28, 2017

Hiya
First pull request being for changes just so I could build and import to IDE.

  • No gradlew wrapper present so didn't know which version to use for building. I added 3.5 because it matched the version in gradle-wrapper.properties but happy to use whatever version you dictate.
  • ide metadata should not be present (added .classpath, .project, .settings to .gitignore and removed)
  • removed gradle metadata (.gradle was present though in .gitignore)

Oh to save you some time perhaps (I know you work across a lot of languages!), to import the project into eclipse:

./gradlew eclipse

and import as eclipse project as usual.

@davidmoten davidmoten changed the title fix gradle setup and .gitignore fix gradle setup and .gitignore and test Nov 28, 2017
@caitlinrussell caitlinrussell force-pushed the master branch 2 times, most recently from 86961e3 to 631c483 Compare November 28, 2017 22:30
@davidmoten
Copy link
Contributor Author

Yikes, a major rebase job is needed now. I'll sort it.

…ion to .gitignore, remove existing metadata files and bin files
@davidmoten
Copy link
Contributor Author

I've rebased and removed my fixes to test classes, constraining only to setup stuff like gradlew, .gitignore and removing ide metadata etc.

@Cbales can you review this and merge please to avoid more rebase pain?

As part of review what version of gradle do you want to use?

@davidmoten davidmoten changed the title fix gradle setup and .gitignore and test fix gradle setup and .gitignore Nov 29, 2017
@caitlinrussell
Copy link

Thanks so much for the cleanup! I hadn't looked into the included files yet and definitely should have before anyone cloned it. I also did a rebase myself to remove another file, so after we merge this in, you'll want to clone again as well I believe.
The plan right now is to support Gradle 3.5

@caitlinrussell caitlinrussell merged commit 0871cea into microsoftgraph:master Nov 29, 2017
@davidmoten
Copy link
Contributor Author

Beaut. git pull on master and no conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants