Skip to content

Load credentials and signing info from local.properties #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deepak2016 merged 1 commit into from
Sep 27, 2018
Merged

Load credentials and signing info from local.properties #146

deepak2016 merged 1 commit into from
Sep 27, 2018

Conversation

@NakulSabharwal
Copy link
Contributor

@NakulSabharwal NakulSabharwal commented Sep 27, 2018

Changes proposed in this pull request

  • Loading of signing signing.secretKeyRingFile, signing.keyId, signing.password and enableSigning from local.properties for publishing to maven central release.

deepak2016
deepak2016 approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@deepak2016 deepak2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@deepak2016 deepak2016 merged commit 8423c94 into dev Sep 27, 2018
@deepak2016 deepak2016 deleted the credentials-loading-task branch October 23, 2018 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@deepak2016 deepak2016 deepak2016 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NakulSabharwal @deepak2016