Skip to content

Conversation

@gazgeek
Copy link

@gazgeek gazgeek commented Nov 5, 2018

Override constructors to allow for a custom IHttpURLConnectionProvider to be provided.
This allows for a convenient way to set the read and connect timeouts.

Changes proposed in this pull request

  • Allow for a custom HttpURLConnection to be provided for GraphServiceClient. This makes it easy to set the read and connect timeouts - something that is not currently possible

…lient

Override constructors to allow for a custom IHttpURLConnectionProvider to be provided.
This allows for a convenient way to set the read and connect timeouts.
@msftclas
Copy link

msftclas commented Nov 5, 2018

CLA assistant check
All CLA requirements met.

@gazgeek
Copy link
Author

gazgeek commented Nov 14, 2018

I'm not clear why "msgraph-sdk-java build and packaging" is failing. I don't have access to click the link.

Is it related to there not being an approval or is there something for me to fix?

Thanks

@deepak2016
Copy link
Contributor

@gazgeek This is infra related issue and you don't need to fix anything due to this error. We are looking into this issue.

@NakulSabharwal
Copy link
Contributor

@gazgeek This issue of configuring timeouts has been fixed in this PR #216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants