Skip to content

Conversation

@Krisoblucki-okta
Copy link

@Krisoblucki-okta Krisoblucki-okta commented Dec 12, 2018

fixes #176

@Krisoblucki-okta
Copy link
Author

@deepak2016 what is the review process for these?

@deepak2016
Copy link
Contributor

@Krisoblucki-okta thanks for opening the issue and raising the PR to fix it. Code in the generated folder is always generated using templates and we have generator code. We don't modify this code directly in the SDK. However, we can modify any code in extension folders.

@deepak2016
Copy link
Contributor

Changes you have proposed, does that fix the issue?

@Krisoblucki-okta
Copy link
Author

@deepak2016 yes, totally understand the cycle, the PR is just a fix proposal and it does address the issue.

@Krisoblucki-okta
Copy link
Author

Krisoblucki-okta commented Dec 14, 2018

@deepak2016 what is eta of such things getting merged? I need to figure out if I should make this change in my branch and roll with that or whether I should wait on you guys to make the change and cut a new version.

@deepak2016
Copy link
Contributor

@Krisoblucki-okta we are working on the fix. This fix will have to go to https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator branch, which is used to generate code used here. This should take around a week time to get fixed. We are investigating if this issue is limited to ProfilePhoto or is common with all stream classes.

@Krisoblucki-okta
Copy link
Author

@deepak2016 thanks for the update, I'll look for v1.0.2 then

@Krisoblucki-okta
Copy link
Author

@deepak2016 @NakulSabharwal wondering if this ended up being addressed already?

@baywet baywet self-assigned this Aug 17, 2020
@github-actions

This comment has been minimized.

@baywet baywet added this to the 2.1.1 milestone Sep 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2020

Conflicts have been resolved. A maintainer will take a look shortly.

@baywet baywet modified the milestones: 2.1.1, 2.1.0 Sep 9, 2020
@baywet
Copy link
Member

baywet commented Sep 9, 2020

Hi @Krisoblucki-okta
Thanks for submitting this PR and thank you for your patience.
After solving the conflicts of the pull request, it appears it didn't solve the original issue.
I've authored PR #454 which solves the issue. This PR will be closed when the PR I authored gets merged.
Sorry we couldn't get your PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

graphServiceClient.users(userId).photo().getContent().buildRequest().put(imageBytes) throws java.lang.ClassCastException

3 participants