-
Notifications
You must be signed in to change notification settings - Fork 145
An attempt to cast BufferedInputStream to ProfilePhoto fails #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes issue 176
|
@deepak2016 what is the review process for these? |
|
@Krisoblucki-okta thanks for opening the issue and raising the PR to fix it. Code in the generated folder is always generated using templates and we have generator code. We don't modify this code directly in the SDK. However, we can modify any code in extension folders. |
|
Changes you have proposed, does that fix the issue? |
|
@deepak2016 yes, totally understand the cycle, the PR is just a fix proposal and it does address the issue. |
|
@deepak2016 what is eta of such things getting merged? I need to figure out if I should make this change in my branch and roll with that or whether I should wait on you guys to make the change and cut a new version. |
|
@Krisoblucki-okta we are working on the fix. This fix will have to go to https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator branch, which is used to generate code used here. This should take around a week time to get fixed. We are investigating if this issue is limited to ProfilePhoto or is common with all stream classes. |
|
@deepak2016 thanks for the update, I'll look for v1.0.2 then |
|
@deepak2016 @NakulSabharwal wondering if this ended up being addressed already? |
This comment has been minimized.
This comment has been minimized.
|
Conflicts have been resolved. A maintainer will take a look shortly. |
|
Hi @Krisoblucki-okta |
fixes #176