Skip to content

Send attachment with mail #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
baywet merged 10 commits into from
Sep 9, 2020
Merged

Send attachment with mail #202

baywet merged 10 commits into from
Sep 9, 2020

Conversation

@NakulSabharwal
Copy link
Contributor

@NakulSabharwal NakulSabharwal commented Jan 6, 2019 •
edited by baywet
Loading

Fixes #192
Fixes #90

Changes proposed in this pull request

  • Serializer for attachments.
  • Tests for sending attachment with email.
  • Expose attachment attribute

@baywet baywet self-assigned this Aug 17, 2020
@github-actions

This comment has been minimized.

Sign in to view
@baywet baywet added this to the 2.0.1 milestone Sep 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2020

Conflicts have been resolved. A maintainer will take a look shortly.

baywet
baywet previously approved these changes Sep 8, 2020
View reviewed changes
This was referenced Sep 8, 2020
Closed
Closed
Merged
This was referenced Sep 9, 2020
Merged
Merged
MIchaelMainer
MIchaelMainer approved these changes Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed online with Vincent

@baywet baywet merged commit dd7778c into dev Sep 9, 2020
@baywet baywet deleted the attachment-bug-fix branch September 9, 2020 15:44
@baywet baywet mentioned this pull request Sep 18, 2020
Closed
@Przemek-12
Copy link

Przemek-12 commented Oct 2, 2020 •
edited
Loading

Hi, I can't send mail message with attachment. I use exact same code as in unit tests. I get NoSuchMethodException at CollectionPageSerializer class, line 84.
java.lang.NoSuchMethodError: 'com.google.gson.JsonElement com.google.gson.JsonParser.parseString(java.lang.String)'.
In JsonParser class, there's no parseString method. There's only parse(String json).

@baywet
Copy link
Member

baywet commented Oct 2, 2020

hi @Przemek-12
Can you open a separate issue please so it's easier for us to have a focused discussion?
Thanks!

@Przemek-12
Copy link

Przemek-12 commented Oct 2, 2020

hi, just opened it: #515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MIchaelMainer MIchaelMainer MIchaelMainer approved these changes

@baywet baywet baywet left review comments

@zengin zengin Awaiting requested review from zengin

Assignees

@baywet baywet

Labels

None yet

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

Not able to send attachment with this API https://graph.microsoft.com/v1.0/me/sendMail send email with attachments

5 participants

@NakulSabharwal @Przemek-12 @baywet @MIchaelMainer