Core integration #254
Merged
Core integration #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muthurathinam
previously approved these changes
May 27, 2019
muthurathinam
previously approved these changes
May 27, 2019
naveenkumaragarwal-zz
suggested changes
May 28, 2019
src/main/java/com/microsoft/graph/concurrency/ChunkedUploadResponseHandler.java
Show resolved
Hide resolved
|
|
||
| sb.append(" {"); | ||
| if (isVerbose) { | ||
| sb.append(bytes); |
There was a problem hiding this comment.
this wont convert byte array to readable string. it will convert to object signature, create a method to convert byte array to string which can be used multiple places.
Contributor
Author
There was a problem hiding this comment.
This will be changing the current behavior, will need to discuss on that.
peombwa
requested changes
May 29, 2019
NakulSabharwal
requested review from
muthurathinam,
naveenkumaragarwal-zz and
peombwa
muthurathinam
approved these changes
May 31, 2019
peombwa
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request