Update drive item #315
Closed
Update drive item #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad-generics fix raw type usage in ChunkedUploadResult
March Updates
This reverts commit 0de077a.
TIL never edit in GH
Bringing in changes from released dev branch to master branch
November 2018 updates
January 2019 updates
February 2019 Updates
May updates 2019
Dev to master merge
July 2019 dev to master merge
Generated v1.0 models and request builders using Typewriter (microsoftgraph#311) - …
|
|
added 2 commits
October 30, 2019 11:14
Member
|
Hey @yudix thanks for the PR! |
Author
|
Hi,
It was indeed a long time ago, and some of my code indeed merged with
another developers PR...
Now, there is a support for conflict behavior in java
driveItem.additionalDataManager().put("@microsoft.graph.conflictBehavior
But when I send the PR the code on the doc
https://docs.microsoft.com/en-us/graph/api/driveitem-post-children?view=graph-rest-1.0&tabs=java
Was not even compile.
Now, it just a workaround and not a Java solution, I implement an enum for
this, and also there is no much info what type of conflict behavior one
should expect...
Sorry, I probably will not send more PR's, Thanks for your attention but it
is too late.
yudix.
…On Tue, Aug 18, 2020, 22:59 Vincent Biret ***@***.***> wrote:
Hey @yudix <https://github.com/yudix> thanks for the PR!
I'm doing a cleanup of the repo (I'm new here), trying to align branches,
close issues that are already resolved and merged pull requests which
waited a while.
To me it looks like most of you changes were already in master, but never
merged back in dev, see #414
<#414>
Can you explain further why you added the property on the Drive item
please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#315 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5H4JIUAT5QM47X3RVCKHLSBLMSLANCNFSM4JGVY7NQ>
.
|
Member
|
thanks for the quick reply and sorry it took so long to this PR to get looked at. Closing now that we have all the pieces in place (patch in the handlers, additional properties manager and docs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.