Planner helpers #34
Merged
Planner helpers #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
December 1, 2017 13:50
Planner takes some time to set up and tear down resources such as tasks and buckets, so we'll reuse the same items for each test in the suite.
Although this is how the class is used [see Update PlannerPlanDetails](https://developer.microsoft.com/en-us/graph/docs/api-reference/v1.0/api/plannerplandetails_update), the service expects a JSON object and not a JSON array. Therefore, this breaks de/serialization in the SDK.
Also created a new test plan
davidmoten
reviewed
Jan 27, 2018
| * The class for the Base Planner Assignments. | ||
| */ | ||
| public class BasePlannerAssignments implements IJsonBackedObject { | ||
| public class BasePlannerAssignments extends HashMap<String, PlannerAssignment> implements IJsonBackedObject { |
Contributor
There was a problem hiding this comment.
The only reason I can see for extending HashMap is to support the put method. Rather than expose (and be forced to support) the huge HashMap api why not use composition instead of inheritance here (and only expose the put method)?
Author
There was a problem hiding this comment.
You are correct on this.
However, since this is helper code written in C# and ported over to Java, and because we are trying to minimize our costs on custom code like this, I'll leave it as-is.
davidmoten
approved these changes
Jan 30, 2018
MIchaelMainer
approved these changes
Feb 20, 2018
Collaborator
MIchaelMainer
left a comment
MIchaelMainer
left a comment
There was a problem hiding this comment.
Related to microsoftgraph/MSGraph-SDK-Code-Generator#114.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These helpers do a few things: