Skip to content

- fixes a bug where jwts would be shown in error messages #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
baywet merged 1 commit into from
Sep 3, 2020
Merged

- fixes a bug where jwts would be shown in error messages #447

baywet merged 1 commit into from
Sep 3, 2020

Conversation

@baywet
Copy link
Member

@baywet baywet commented Sep 3, 2020 •
edited
Loading

Fixes #387

Changes proposed in this pull request

  • error messages look like this instead of containing the JWT
PUT https://graph.microsoft.com/v1.0/groups/263746d9-2294-4506-87c4-7d4a50d81332/team
SdkVersion : graph-java/v2.0.0
Authorization : [PII_REDACTED]
{"funSettings":{"allowCustomMemes":false},"memberS[...]

Other links

@baywet baywet added this to the 2.0.1 milestone Sep 3, 2020
@baywet baywet self-assigned this Sep 3, 2020
@baywet baywet mentioned this pull request Sep 3, 2020
Closed
@baywet baywet merged commit d3f9294 into dev Sep 3, 2020
@baywet baywet deleted the bugfix/jwt-redaction-error-messages branch September 3, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

1 more reviewer

@zengin zengin zengin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@baywet baywet

Labels

None yet

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

Print accessToken when error happened

3 participants

@baywet @zengin