Target Java 7 #72
Target Java 7 #72
Conversation
MIchaelMainer
left a comment
MIchaelMainer
left a comment
There was a problem hiding this comment.
Learned about Java map versus hashmap. Thank you for op!
| * This generated file contains a sample Java Library project to get you started. | ||
| * For more details take a look at the Java Libraries chapter in the Gradle | ||
| * user guide available at https://docs.gradle.org/3.5/userguide/java_library_plugin.html | ||
| * user guide available at https://docs.gradle.org/4.5/userguide/java_library_plugin.html |
|
|
||
| compile 'com.sun.jersey:jersey-server:1.19.4' | ||
| } | ||
|
|
There was a problem hiding this comment.
The publishing section is needed so I can call ./gradlew publishToMavenLocal to generate maven artifacts locally. By all means use the properties ${mavenMajorVersion} etc. By the way in the dev branch gradle.properties should have majorPatchVersion=0-SNAPSHOT. It should only get the release version in master branch or in the tag (if I have your workflow correct).
There was a problem hiding this comment.
Since we will not be publishing snapshots or nightlies, we do not need to worry about changing the release version.
There was a problem hiding this comment.
Added publishing section back in
There was a problem hiding this comment.
Thanks. You might not be publishing snapshots or nightlies but any dev should be able to rebuild the release jar at the specificed version locally from whatever branch or tag without manual modification of build.gradle. For this reason the SNAPSHOT belongs in gradle.properties (or to be specific the publishing section version should always match the gradle.properties version).
build.gradle
Outdated
|
|
||
| artifactId 'microsoft-graph' | ||
|
|
||
| version '${mavenMajorVersion}.${mavenMinorVersion}.SNAPSHOT' |
There was a problem hiding this comment.
need the patch version too and should be -SNAPSHOT
|
|
||
| compile 'com.sun.jersey:jersey-server:1.19.4' | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks. You might not be publishing snapshots or nightlies but any dev should be able to rebuild the release jar at the specificed version locally from whatever branch or tag without manual modification of build.gradle. For this reason the SNAPSHOT belongs in gradle.properties (or to be specific the publishing section version should always match the gradle.properties version).
The SDK must support Java versions >= 7 but was not set to compile to a specific version (so compiled at whatever version the developer had on their machine, in this case, Java 8).