Workload helper updates #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIchaelMainer
requested changes
Mar 6, 2018
|
|
||
| /** | ||
| * Add an image part to the multipart body | ||
| * Add an image/jpeg part to the multipart body |
Collaborator
There was a problem hiding this comment.
Does OneNote only support adding jpegs? If so, let's rename this from addImagePart to addJpegPart. If it supports other types, we may want to consider adding an enum of supported image types.
Author
There was a problem hiding this comment.
I don't think that this helps much more than just using the addFilePart so I'll just remove it
MIchaelMainer
previously approved these changes
Mar 7, 2018
Doesn't really save much code and is confusing because an image can be many types other than jpeg
davidmoten
approved these changes
Mar 7, 2018
|
|
||
| /** | ||
| * Add a string part to the multipart body | ||
| * @param name The name of the part |
|
|
||
| /** | ||
| * Add a file part to the multipart body | ||
| * @param name The name of the part |
MIchaelMainer
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12f6b8e - Add helper for multipart header and update OneNote multipart test to use header
88f0cb6 - Add default @odata.type parameters for Planner models, so the user does not need to specify them herself