fix(zod): include array items schema in JSON schema output (#104)#104
Merged
dinwwwh merged 1 commit intomiddleapi:mainfrom Feb 1, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
Thanks for your PR! Unfortunately, I can't merge it just yet. We'll need to wait until the new builder is released, as the current branch has significant issues with the lazy router. Merging this now wouldn't allow for a release anyway. I appreciate your understanding! |
More templates
@orpc/client
@orpc/contract
@orpc/openapi
@orpc/server
@orpc/shared
@orpc/react-query
@orpc/vue-colada
@orpc/vue-query
@orpc/zod
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found the relevant code and added this myself. Would like to help with issues like this where I can :)
Might be worth considering changing the test to not involve arrays (e.g. left/right instead of children, or a linked list instead of a tree), as it seems to be testing two features (lazy + arrays). The original test wasn't actually testing the lazy functionality as the converter wouldn't recurse into the array.
Fixes #102