Adding cargo semver checks#54
Open
seattlelizzard wants to merge 1 commit into
Open
Conversation
just putting defaults in and seeing if it works. Should since cargo.toml is at project root
Collaborator
|
Thanks for the PR! 🏅 |
Collaborator
|
This patch would have cargo semver checks running on each PR against develop. This would be redundant since the check only makes sense to run on releases - PRs against develop do not tend to involve a cargo version bump, which would make the semver checks useless, if I understand correctly. One thing we could do is have the checks run only for PRs against |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding cargo semver checks to Github actions yaml