fix(backfill): restore MUI 3.x equality guard, gated on lib_Version#3
Merged
fix(backfill): restore MUI 3.x equality guard, gated on lib_Version#3
Conversation
Commit 6e678e4 removed the long-standing "stuntzi" early-return guard in the MUIM_Backfill handler so MUI 4/5 would stop rendering as a blue checkerboard. That regressed MUI 3.8 / 3.9, which need the guard to avoid painting outside the gadget bounds. Restore the guard but only apply it when MUIMasterBase->lib_Version <= 20 (MUI 3.9 = v20, MUI 3.8 = v19). MUI 4+ (v21+) keeps the unguarded path introduced for the checkerboard fix. Verified working on both MUI 3.8 and MUI 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MUIMasterBase->lib_Version <= 20(MUI 3.9 = v20, MUI 3.8 = v19). MUI 4+ (v21+) keeps the unguarded path that fixed the checkerboard.Test plan
make OS=os3rebuilds HTMLview.mcc cleanly